LLVM update 43d71ba #3086
LLVM update 43d71ba #3086
Conversation
brnorris03
force-pushed
the
llvm-update-0e779ad
branch
from
7a108f7 to
599ab54
Compare
brnorris03
force-pushed
the
llvm-update-0e779ad
branch
from
845bce1 to
73368d5
Compare
|
@AlexandreEichenberger -- this seems like a rather large update, so I could use some help. There were a lot of TOSA dialect changes, and I am going through lit tests now and updating them (no problems there so far) -- should be done today hopefully. The However, most of the backend tests fail, e.g., in the |
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
brnorris03
force-pushed
the
llvm-update-0e779ad
branch
from
73368d5 to
09ca5c1
Compare
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
… machines Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
|
|
||
| auto int8Type = rewriter().getI8Type(); | ||
| auto shiftValue = TosaBuilder::createConst( | ||
| ArrayRef<int8_t>{static_cast<int8_t>(shift)}, {1}, int8Type); |
There was a problem hiding this comment.
IMO its better to change the TosaBuilder::mul parameter shift to int8_t isntead of having this hidden cast inside the function
There was a problem hiding this comment.
Can you elaborate a bit more what you mean by "change the TosaBuilder::mul parameter shift" -- change it where?
There was a problem hiding this comment.
I mean the function signature: Value TosaBuilder::mul(Value &lhs, Value &rhs, int32_t shift).
Right now it takes an int32_t paramter and internally cast it to int8_t.
I would prefer it to change the function signature to Value TosaBuilder::mul(Value &lhs, Value &rhs, int8_t shift) so that it is clear for callers that it only supports int8 shift values
|
@jorickert thanks for helping with the TOSA related updates. |
Signed-off-by: Boyana Norris <[email protected]>
Signed-off-by: Boyana Norris <[email protected]>
Thanks! I did have everything passing locally, but the stablehlo build failed CI. So I updated the llvm and stablehlo versions again, which brought in another pile of TOSA changes; everything builds but I have not had a chance to update all the lit tests yet. |
LLVM: llvm/llvm-project@43d71ba
Stablehlo: openxla/stablehlo@5e9b356 (v1.9.4)